Project

General

Profile

Actions
Copy link

Bug #64511

open

kv/RocksDBStore: rocksdb_cf_compact_on_deletion has no effect on the default column family

Added by Joshua Baergen 3 months ago. Updated about 23 hours ago.

Status:
Pending Backport
Priority:
Normal
Assignee:
Joshua Baergen
Target version:
Ceph - v20.0.0
% Done:

0%

Source:
Community (user)
Tags:
backport_processed
Backport:
quincy reef squid
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
Ceph - v16.2.15, Ceph - v17.2.7, Ceph - v18.2.3
ceph-qa-suite:
Pull request ID:
55676
Crash signature (v1):
Crash signature (v2):

Description

This setting is applied via update_column_family_options(), which is called for each configured CF but not for the default one (at least for upgraded systems that have not been resharded - I could be misunderstanding the flow for resharded/new systems). This is a big deal for upgraded systems since the bulk of rocksdb data lives in the default CF.

Related issues 3 (3 open — 0 closed)

Copied to bluestore - Backport #65914: quincy: kv/RocksDBStore: rocksdb_cf_compact_on_deletion has no effect on the default column familyIn ProgressKonstantin ShalyginActions
Copied to bluestore - Backport #65915: squid: kv/RocksDBStore: rocksdb_cf_compact_on_deletion has no effect on the default column familyIn ProgressKonstantin ShalyginActions
Copied to bluestore - Backport #65916: reef: kv/RocksDBStore: rocksdb_cf_compact_on_deletion has no effect on the default column familyIn ProgressKonstantin ShalyginActions
Actions
Copy link
 #1

Updated by Joshua Baergen 3 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 55676
Actions
Copy link
 #2

Updated by Igor Fedotov 2 months ago

  • Project changed from RADOS to bluestore
Actions
Copy link
 #3

Updated by Konstantin Shalygin 21 days ago

  • Status changed from Fix Under Review to Pending Backport
  • Target version set to v20.0.0
  • Source set to Community (user)
  • Backport set to quincy reef squid
  • Affected Versions v16.2.15, v18.2.3 added
  • Affected Versions deleted (v16.2.14, v18.2.0, v18.2.1)
Actions
Copy link
 #4

Updated by Steven Goodliff 17 days ago

Hi,

Will this fix get into 18.2.3 ?, thanks

Actions
Copy link
 #5

Updated by Konstantin Shalygin 17 days ago

Steven Goodliff wrote in #note-4:

Hi,

Will this fix get into 18.2.3 ?, thanks

Seems, backport bot is broken. The backport issues wasn't crated for a days

Actions
Copy link
 #6

Updated by Steven Goodliff 8 days ago

will someone fix the backport bot ?, were thinking about upgraded to a version that has this fix in hence the question. Thanks

Actions
Copy link
 #7

Updated by Casey Bodley 8 days ago

  • Copied to Backport #65914: quincy: kv/RocksDBStore: rocksdb_cf_compact_on_deletion has no effect on the default column family added
Actions
Copy link
 #8

Updated by Casey Bodley 8 days ago

  • Copied to Backport #65915: squid: kv/RocksDBStore: rocksdb_cf_compact_on_deletion has no effect on the default column family added
Actions
Copy link
 #9

Updated by Casey Bodley 8 days ago

  • Copied to Backport #65916: reef: kv/RocksDBStore: rocksdb_cf_compact_on_deletion has no effect on the default column family added
Actions
Copy link
 #10

Updated by Casey Bodley 8 days ago

  • Tags set to backport_processed
Actions
Copy link
 #11

Updated by Konstantin Shalygin 8 days ago

Steven Goodliff wrote in #note-6:

will someone fix the backport bot ?, were thinking about upgraded to a version that has this fix in hence the question. Thanks

I was make some noise on dev list, Casey pushed backports now

Actions
Copy link
 #12

Updated by Steven Goodliff about 23 hours ago

Thanks guys, much appreciated

Actions
Copy link

Also available in: Atom PDF